Skip to content

fix!: Remove trailing uninitialized bytes in the binary result array #26557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix!: Remove trailing uninitialized bytes in the binary result array #26557

wants to merge 1 commit into from

Conversation

@shanhao-203
Copy link

@shanhao-203 shanhao-203 commented Nov 7, 2025 •
edited
Loading

Summary:
Remove the uninitialized bytes in binaryData, so we can reduce the binary response size.

{F1983340076}

Differential Revision: D85720910

@shanhao-203 @facebook-github-bot
remove trailing uninitialized bytes in the binary result array
2209dc6 
Summary:
Remove the uninitialized bytes in binaryData, so we can reduce the binary response size.

 {F1983340076}

Differential Revision: D85720910
@shanhao-203 shanhao-203 requested a review from a team as a code owner November 7, 2025 07:18
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 7, 2025

CLA Not Signed

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 7, 2025 •
edited
Loading

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Modify how binary page data is base64-encoded to avoid including trailing uninitialized bytes by encoding only the valid portion of the byte array.

File-Level Changes

Change Details Files
Trim uninitialized bytes before base64 encoding
  • Extract raw byte array from sliceOutput
  • Use BaseEncoding.base64().encode with explicit offset and length
  • Remove use of BASE64_ENCODER.encodeToString on full byte array
 Query.java
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Nov 7, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@shanhao-203 shanhao-203 changed the title remove trailing uninitialized bytes in the binary result array fix!: Remove trailing uninitialized bytes in the binary result array Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shanhao-203 @facebook-github-bot